D16341: Minor cleanups of TabSwitcher plugin

[gregormi]

gregormi added a comment.


  One thing about the memleak. I tried to find it just be running valgrind
  
  valgrind --leak-check=yes kate
  
  I got something like this:
  
    ==6196== 2,018 (192 direct, 1,826 indirect) bytes in 4 blocks are definitely lost in loss record 7,067 of 7,126
    ==6196==    at 0x4C2E04F: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==6196==    by 0x720EF97: ??? (in /usr/lib64/libstdc++.so.6.0.25)
    ==6196==    by 0x1ED10EA1: ??? (in /home/gregor/kde/usr/lib64/plugins/ktexteditor/tabswitcherplugin.so)
    ==6196==    by 0x1ED1038A: ??? (in /home/gregor/kde/usr/lib64/plugins/ktexteditor/tabswitcherplugin.so)
    ==6196==    by 0x1ED100DC: ??? (in /home/gregor/kde/usr/lib64/plugins/ktexteditor/tabswitcherplugin.so)
    ==6196==    by 0x452322: ??? (in /home/gregor/kde/usr/bin/kate)
    ==6196==    by 0x451FA9: ??? (in /home/gregor/kde/usr/bin/kate)
  
  I wonder why symbol names and line numbers are missing. I checked if debug_info is present:
  
    $ file /home/gregor/kde/usr/lib64/plugins/ktexteditor/tabswitcherplugin.so
    /home/gregor/kde/usr/lib64/plugins/ktexteditor/tabswitcherplugin.so: ELF 64-bit LSB pie executable x86-64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=1797b5bed64b6cd245c08c927af421438b646d0c, with debug_info, not stripped
    
    $ file kate
    kate: ELF 64-bit LSB executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=0b925b6b1beed50b776eac581b7cb018e99063ae, with debug_info, not stripped
  
  Is there something else I can check to find out why symbols are not found?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D16341

To: dhaumann, gregormi
Cc: kwrite-devel, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181021/864906ec/attachment.html>