D16341: Minor cleanups of TabSwitcher plugin

Dominik Haumann noreply at phabricator.kde.org
Sat Oct 20 20:31:39 BST 2018


dhaumann created this revision.
dhaumann added a reviewer: gregormi.
Herald added a project: Kate.
Herald added a subscriber: kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  Changes include:
  
  - fix one memory leak
  - use KTextEditor::Document in model data
  - avoid using QStandardItem, since no standard models are used
  
  This is a follow-up change to 47cf54ddf423f4765b406ebe3e0cb8dcc5ca52a2 <https://phabricator.kde.org/R40:47cf54ddf423f4765b406ebe3e0cb8dcc5ca52a2>

TEST PLAN
  manual testing

REPOSITORY
  R40 Kate

BRANCH
  tabswitcher-cleanups (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16341

AFFECTED FILES
  addons/tabswitcher/tabswitcher.cpp
  addons/tabswitcher/tabswitcherfilesmodel.cpp
  addons/tabswitcher/tabswitcherfilesmodel.h
  addons/tabswitcher/tests/CMakeLists.txt
  addons/tabswitcher/tests/tstestapp.cpp

To: dhaumann, gregormi
Cc: kwrite-devel, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181020/86c929a5/attachment.html>


More information about the KWrite-Devel mailing list