D15804: Fix Duplicates on Quick Open File

[Sven Brauch]

brauch added a comment.


  Code-wise this looks fine to me otherwise.

INLINE COMMENTS

> katequickopenmodel.cpp:17
> +{
> +    Q_UNUSED(parent);
> +    return m_modelEntries.size();

I'd put if parent.isValid() { return 0; } instead.

> katequickopenmodel.cpp:86
> +    beginResetModel();
> +        m_modelEntries = allDocuments;
> +    endResetModel();

strange indent

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D15804

To: tcanabrava, cullmann, brauch, neundorf
Cc: dhaumann, anthonyfieroni, kwrite-devel, michaelh, ngraham, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181011/ecd31283/attachment.html>