D16830: WIP: Tabbar: Add 'File Properties' menu item and three more (Rename, Delete and Compare)

[Dominik Haumann]

dhaumann added a comment.


  In general I have no objections to this patch. I'd welcone another review, though.

INLINE COMMENTS

> katemainwindow.cpp:734
> +{
> +    bool hasUrl = false;
> +    auto&& view = viewManager()->activeView();

move down:

  const bool hasUrl = view && !view->document()->url().isEmpty();

This way you don't need an if at all, thr code is more compact and more readable.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D16830

To: gregormi, #kate
Cc: anthonyfieroni, dhaumann, mmustac, ngraham, kwrite-devel, michaelh, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181126/08d98bf6/attachment.html>