D17128: DocumentPrivate: Remove comment mark when joining lines

[loh tar]

loh.tar added a comment.


  > I am not sure if the normal join lines should try to be that clever.
  
  But consider the "auto comment" feature after you hit "Return", it's also somehow "special clever" but very useful. This tries to add the corresponding functionality. Well, the true opposite would be when you hit "Del" at the on of a line. Yeah, sounds good, will look at that too but it is (almost, see next note) independent from this aim.
  
  I'm currently digging into the wrap functionally which is broken since a decade BUG135737 <https://bugs.kde.org/show_bug.cgi?id=135737>. Sometimes it works already pretty well (with normal text) but sometimes it drives nuts (without selection in a code file). Very strange. Why I mention this? There I have follow a suggestion posted in that bug report, just o trigger a "Return" input at the right place. Now, while writing this text I came up with this "Del" idea. So, it may a good idea to re-design this patch (?)
  
  > It would make more sense to have an extra action for such a "smart" variant in my eyes.
  
  An extra action looks to me at first sight a little overdone, but an option how join behaves may appropriate. Let me know where to place that in the Edit Options page if you (and other) like that idea

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, ngraham, bruns, demsking, head7, kfunk, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181125/802900f8/attachment-0001.html>