D16779: kate-ctags plugin: support KDevelop (WIP)

René J.V. Bertin noreply at phabricator.kde.org
Tue Nov 13 17:29:06 GMT 2018


rjvbb updated this revision to Diff 45427.
rjvbb added a comment.


  This adds a safety against a race-like condition I've seen happen once in KDevelop.
  It may not be required to make m_mWin a QPointer but it seemed sensible to do.
  
  Somehow this plugin causes duplicate context menu entries in KDevelop documents, apparently because the CTags context submenu is added via KXMLGUI. I have an initial fix for KDevelop for that; I'll wait with committing this until that issue has been addressed.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16779?vs=45176&id=45427

REVISION DETAIL
  https://phabricator.kde.org/D16779

AFFECTED FILES
  addons/kate-ctags/kate_ctags_plugin.cpp
  addons/kate-ctags/kate_ctags_view.cpp
  addons/kate-ctags/kate_ctags_view.h
  addons/kate-ctags/katectagsplugin.desktop
  addons/kate-ctags/ui.rc

To: rjvbb, #kate, sars
Cc: sars, kdevelop-devel, kwrite-devel, #kde_applications, glebaccon, antismap, michaelh, iodelay, vbspam, ngraham, demsking, geetamc, head7, Pilzschaf, akshaydeo, surgenight, arrowd, cullmann, kfunk, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181113/a2339c99/attachment.html>


More information about the KWrite-Devel mailing list