D16370: KTextEditor : syntax definition priority UI usability

[René J.V. Bertin]

rjvbb added inline comments.

INLINE COMMENTS

> dhaumann wrote in katemodeconfigpage.cpp:95
> I would prefer to set this in the ui file: The maximum is already set to 99. I think it makes sense to set the minimum to -99 there. Can you provide an updated patch?

Actually, 99 must be the default maximum because I couldn't find where it's set in the ui file...

> dhaumann wrote in katemodeconfigpage.cpp:97
> I agree with Christoph, we have no tooltip anywhere so far, so this would be inconsistent.
> 
> @ngraham Do you have any comment on this from a usability perspective? I have the feeling that how to show whats-this infos should be maybe solved in a more general way, and not for just one specific spin box.

I'm removing the tooltip then. There's very little place to add an explicative label; the only thing I can imagine is adding one somewhere that says something like "select a control and hit Shift-F1 for instructions"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D16370

To: rjvbb, #ktexteditor
Cc: dhaumann, ngraham, cullmann, kde-frameworks-devel, kwrite-devel, michaelh, bruns, demsking, head7, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181112/1334d51c/attachment-0001.html>