D13138: Re-allow running Kate and KWrite as the actual root user (but still not using sudo)

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Kate, dhaumann, cullmann.
Restricted Application added a project: Kate.
Restricted Application added a subscriber: kwrite-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The original change (9adcebd3c2e476c8a32e9b455cc99f46b0e12a7e <https://phabricator.kde.org/R40:9adcebd3c2e476c8a32e9b455cc99f46b0e12a7e>) to prevent sudo usage broke the use case of running KWrite or Kate while logged in as the actual `root` user with a GUI session. This is how the Kali distro is set up by default, so the original change amounted to making Kate and KWrite not launch at all on this KDE distro.
  
  This patch re-enables running as the actual root user, but keeps blocking usage via `sudo` or `kdesu`.
  
  I have submitted a similar change for Dolphin that has been accepted (D12795 <https://phabricator.kde.org/D12795>), but @elvisangelaccio wants that to go in at the same time as this, to keep them in sync.
  
  BUG: 387973
  FIXED-IN: 18.08.0

TEST PLAN
  - Log in as normal user and run `sudo kate` or `sudo kwrite`: you get an error message.
  - Log in as normal user and run `kdesu kate` or `kdesu kwrite`: you get an error message.
  - Log in as the root user and run Kate or KWrite normally: it works.

REPOSITORY
  R40 Kate

BRANCH
  allow-running-as-the-actual-root-user (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13138

AFFECTED FILES
  kate/main.cpp
  kwrite/main.cpp

To: ngraham, #kate, dhaumann, cullmann
Cc: kwrite-devel, elvisangelaccio, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180526/f23e4853/attachment.html>