D13517: Fix QuickOpen with Qt 5.11 (bug 395039)
noreply at phabricator.kde.org
Wed Jun 13 14:33:50 UTC 2018
brauch created this revision.
brauch added reviewers: dhaumann, cullmann.
Restricted Application added a project: Kate.
Restricted Application added a subscriber: kwrite-devel.
brauch requested review of this revision.
Apparently the item model changes in Qt 5.11 cause our quickopen list to be empty.
I do not know why the old code does not work, to be honest, to me it seems okay. The only thing which is definitely wrong is the call to mapToSource; the index passed to this belongs to the model which has since been replaced, and not to the actual model attached to the proxy model. That issue is unrelated though, commenting out that code (and thus removing the feature) doesn't fix it.
I like the suggested implementation better anyways, so I think we should change this in either case, but does anyone have an idea why the old code is broken? Is that maybe even a regression in Qt itself? @mwolff?
To: brauch, dhaumann, cullmann
Cc: kwrite-devel, mwolff, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel