D12897: Reserve space for the cachedLineForRanges Qhash (optimization)
Jaime Torres Amate
noreply at phabricator.kde.org
Sun Jun 10 06:19:25 UTC 2018
jtamate added a comment.
In D12897#276182 <https://phabricator.kde.org/D12897#276182>, @dhaumann wrote:
> @mwolff To me this looks ok - do you see an issue with this? E.g. that KTextEditor will require much more memory for almost no gain?
If there is a more constrained limit, this should be changed, of course.
> I wonder if that really makes sense, given not all blocks contain ranges at all and they not really correlate with the block size.
> Does that change really make it much faster or just shift the costs?
In my tests it doen't really make it much faster, but now the top cost in undo is really the undo method, not QHash memory management.
To: jtamate, #kate, #frameworks
Cc: cullmann, dhaumann, mwolff, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel