D14524: Fix compiler warning -Wimplicit-fallthrough

Dominik Haumann noreply at phabricator.kde.org
Tue Jul 31 20:26:42 BST 2018


dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  syntax-highlighting/src/lib/definition.cpp: In member function ‘void KSyntaxHighlighting::DefinitionData::loadGeneral(QXmlStreamReader&)’:
  syntax-highlighting/src/lib/definition.cpp:523:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
  
    if (elementRefCounter == 0)
    ^~
  
  syntax-highlighting/src/lib/definition.cpp:525:13: note: here
  
    default:
    ^~~~~~~
  
  syntax-highlighting/src/lib/definition.cpp: In member function ‘void KSyntaxHighlighting::DefinitionData::loadFoldingIgnoreList(QXmlStreamReader&)’:
  syntax-highlighting/src/lib/definition.cpp:552:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
  
    if (elementRefCounter == 0)
    ^~
  
  syntax-highlighting/src/lib/definition.cpp:554:13: note: here
  
    default:
    ^~~~~~~

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  removeWarnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14524

AFFECTED FILES
  src/lib/definition.cpp

To: dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180731/472d95e7/attachment.html>


More information about the KWrite-Devel mailing list