D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

[Dominik Haumann]

dhaumann added a comment.


  I just had a look into the code - the Format IDs are currently not used at all by KSyntaxHighlighting. Instead, all format lookups are done via the Format name. And that by definition means that the Format looksups are per Definition, since Formats from different Definitions may have the same name.
  
  In other words, if the lookup of the IDs is good enough on Definition level, then we can change this entirely.
  
  Maybe we can even switch the internal lookup from string-based to id-based, certainly not slower.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14451

To: dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180729/6a36bc9a/attachment.html>