D14434: add functions to access keywords

[Dominik Haumann]

dhaumann added subscribers: asemke, cullmann, vkrause.
dhaumann added a comment.


  In general looks good to me, so +1. I would like to have another +1 from @cullmann, @vkrause or @asemke
  
  What I wonder is whether you really need the keyword lists from the Definition, or whether you want the currently active keyword lists from the current State / Context. I can see that both is useful.

INLINE COMMENTS

> definition.h:175-176
>  
> +    /** Returns the section names of keywords. */
> +    QStringList keywordListsNames() const;
> +    /** Returns a list of keywords for the specified section. */

Could we change this to:

  /**
   * Returns the names of the keyword lists of this Definition.
   * @since 5.49
   * @see keywordList()
   */
  QStringList keywordLists() const;

> definition.h:177-178
> +    QStringList keywordListsNames() const;
> +    /** Returns a list of keywords for the specified section. */
> +    QStringList keywordList(const QString& name) const;
> +

Same here:

  /**
    * Returns the list of keywords for the keyword list @p name.
    * @since 5.49
    * @see keywordLists()
    */
   QStringList keywordList(const QString& name) const;

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14434

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: vkrause, cullmann, asemke, kde-frameworks-devel, kwrite-devel, michaelh, kevinapavew, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180729/e180df04/attachment.html>