D14408: SymbolView: Avoid unneeded update of current item

[loh tar]

loh.tar added a comment.


  > What I still would like to have in this patch is the preventing of the m_currItemTimer from being started while m_updateTimer is active.
  
  Nice, think see what you mean. Stay tuned.

INLINE COMMENTS

> sars wrote in plugin_katesymbolviewer.cpp:179
> I like this change! :)
> 
> Checking pointers should be done close to where you use them.
> 
> I think we even could merge slotRefreshSymbols() with parseSymbols() as the first now just calls the later.

> I think we even could merge slotRefreshSymbols() with parseSymbols() as the first now just calls the later.

Is that a request to do it in this patch? Then I will.

> sars wrote in plugin_katesymbolviewer.cpp:199
> As you noticed this change is not good. It does not decrease the number of calls to parseSymbols() it just adds a delay of 500ms. Notice that cursorPositionChanged and slotDocEdited are connected later in this slot and therefore not trigger any calls to them.

Yes, will revert this

REVISION DETAIL
  https://phabricator.kde.org/D14408

To: loh.tar, #kate, sars
Cc: cullmann, brauch, ngraham, sars, kwrite-devel, #kate, michaelh, kevinapavew, demsking, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180729/d25023f1/attachment.html>