D13826: Support activities when opening files
Dominik Haumann
noreply at phabricator.kde.org
Sat Jul 28 08:31:16 BST 2018
dhaumann added inline comments.
INLINE COMMENTS
> kateapp.cpp:278
> +{
> + for (const auto& window : this->m_mainWindows) {
> + WId id = window->winId();
Please remove this->
> kateappadaptor.h:56
> + */
> + bool isOnActivity(QString activity);
>
Please pass as const reference: const QString &
> main.cpp:313
> + if (answer.size() == 1) {
> + bool canBeUsed = answer.at(0).toBool();
> +
const bool ...
REVISION DETAIL
https://phabricator.kde.org/D13826
To: sscalabrino, #kate, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, michaelh, kevinapavew, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180728/c767bd77/attachment.html>
More information about the KWrite-Devel
mailing list