D14408: SymbolView: Avoid unneeded update of current item

[loh tar]

loh.tar added a comment.


  > You cannot measure the CPU consumption of this particular function by looking at the "System Activity" while scrolling up and down the file.
  
  did not light me
  
  > There are a million other code paths that get executed while you scroll the page.
  
  Of cause
  
  > System Activity gives you an average CPU load of the application during 2000ms. This less than 1ms function only gets called once when you start scrolling and once when you stop.
  
  But these is now gone (?!)
  
  > Sorry, I'm not convinced before I get a trace from a profiler like hotspot, that clearly indicates that this patch would have any noticeable effect.
  
  It really surprised me that you fight so much against this little patch

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D14408

To: loh.tar, #kate, sars
Cc: ngraham, sars, kwrite-devel, #kate, michaelh, kevinapavew, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180727/086c554b/attachment.html>