D14408: SymbolView: Avoid unneeded update of current item
noreply at phabricator.kde.org
Fri Jul 27 15:29:07 BST 2018
loh.tar added a comment.
> You cannot measure the CPU consumption of this particular function by looking at the "System Activity" while scrolling up and down the file.
did not light me
> There are a million other code paths that get executed while you scroll the page.
> System Activity gives you an average CPU load of the application during 2000ms. This less than 1ms function only gets called once when you start scrolling and once when you stop.
But these is now gone (?!)
> Sorry, I'm not convinced before I get a trace from a profiler like hotspot, that clearly indicates that this patch would have any noticeable effect.
It really surprised me that you fight so much against this little patch
To: loh.tar, #kate, sars
Cc: ngraham, sars, kwrite-devel, #kate, michaelh, kevinapavew, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel