D13826: Support activities when opening files

[Dominik Haumann]

dhaumann added a comment.


  Looks already good to me, but one more code iteration would be nice.
  
  @cullmann Any comments from your side?

INLINE COMMENTS

> kateapp.cpp:278
> +{
> +    QStringList allActivities = QStringList();
> +    for (int i = 0; i < this->m_mainWindows.size(); i++) {

Simply writing the following is enough:

  QStringList allActivities;

> kateapp.cpp:279
> +    QStringList allActivities = QStringList();
> +    for (int i = 0; i < this->m_mainWindows.size(); i++) {
> +        WId id = this->m_mainWindows.at(i)->winId();

Can we use range-based for loops here? Same below?

> kateapp.h:194
> +    
> +    QStringList currentActivities();
>  

Could you add API documentation here as well?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D13826

To: sscalabrino, #kate, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, michaelh, kevinapavew, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180708/e95033cf/attachment.html>