D17459: SearchBar: Add Cancel button to stop long running tasks

Dominik Haumann noreply at phabricator.kde.org
Sun Dec 30 13:01:30 GMT 2018

dhaumann added inline comments.


> cullmann wrote in katesearchbar.h:221-227
> This is a purely internal class.
> It is only exported for the unit tests, no header files are installed, therefore any change of the layout is ok ;=)

Yes: as rule of thumb: only classes in the KTextEditor namespace are public API. Everything else can be freely changed. In this case, as Christoph points out, this is purely internal API.

PS: maybe we should have a KTEXTEDITOR_TEST_EXPORT macro to make this explicit. :-)


To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: dhaumann, anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181230/85d8b0ad/attachment.html>

More information about the KWrite-Devel mailing list