D17730: Review KateStatusBar

[loh tar]

loh.tar updated this revision to Diff 48387.
loh.tar retitled this revision from "[WIP] Review KateStatusBar " to "Review KateStatusBar ".
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Remove seemingly unneeded spacing. Well, there is a change but tiny and perhaps to the better
  - Avoid ugly casting in custom menu
  - Remove obviously unneded default stretch values
  - Avoid obviously unneded KLocalizedString members
  - Avoid Q_FOREACH
  - Group some lines more logical
  
  I hope you still like it. Dictionary button will come in extra patch.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17730?vs=48374&id=48387

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181230/a612bb4b/attachment.html>