D17459: SearchBar: Add Cancel button to stop long running tasks

Christoph Cullmann noreply at phabricator.kde.org
Sat Dec 29 19:29:39 GMT 2018

cullmann added inline comments.


> anthonyfieroni wrote in katesearchbar.h:221-227
> You cannot add new members as well, they change object size. Since this class not use pimpl idiom it will be harder to change anything in header except to add new non-virtual functions.

This is a purely internal class.
It is only exported for the unit tests, no header files are installed, therefore any change of the layout is ok ;=)

  R39 KTextEditor


To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181229/a103f559/attachment.html>

More information about the KWrite-Devel mailing list