D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

[Kåre Särs]

sars added inline comments.

INLINE COMMENTS

> katedocument.cpp:117
>  
> -static inline QChar matchingStartBracket(QChar c, bool withQuotes)
> +static inline QChar matchingStartBracket(const QChar &c)
>  {

I'm not familiar with the auto-bracket code, but the change from QChar to const QChar & does not improve the amount of copied data.

Qt documentation: "Most compilers treat it like an unsigned short."

This means that in stead of adding unsigned short to the stack you add the 64bit reference and add the tiny overhead that the reference brings with it.

It probably has no practical difference tho....

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor
Cc: sars, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181220/f90cf627/attachment.html>