D17459: SearchBar: Add Cancel button to stop long running tasks
noreply at phabricator.kde.org
Tue Dec 11 19:38:25 GMT 2018
cullmann added a comment.
I am atm a bit busy, but from principle the code goes into the right direction :)
Thanks for taking this up!
For the input range, I think it would make sense to store it as std::unique_ptr<KTextEditor::MovingRange> to have it taking care of "edits" in-between the calls (even if that is no good idea, but that could avoid some issues, and saves the re-creation of the range in each call)
To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel