D17441: tune editing actions for large number of small edits

Christoph Cullmann noreply at phabricator.kde.org
Sun Dec 9 13:22:43 GMT 2018


cullmann added a comment.


  :P Crash for the win.

INLINE COMMENTS

> katetextblock.cpp:290
> +        // we might need to invalidate ranges or notify about their changes
> +        for (TextRange *range : changedRanges) {
> +            if (range->isValidityCheckRequired()) {

This loop now crash in the unit test

./bin/bug313759

)
=

It works again, if I use a QSet, at that one location.
I think this is some ordering issue, funny.
Need to investigate.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17441

To: cullmann, dhaumann, #kate, loh.tar
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181209/2808b5d2/attachment-0001.html>


More information about the KWrite-Devel mailing list