D17314: Projects Plugin: Add ShellCheck analyzer

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me, but please consider using i18np to enable correct plural translations.

INLINE COMMENTS

> kateprojectcodeanalysistool.h:60
> +     */
> +    virtual QString description() = 0;
> +

make the function const (can be done in a separate patch that also makes name() etc const.

> kateprojectinfoviewcodeanalysis.cpp:246
>      m_messageWidget->setMessageType(KMessageWidget::Information);
> -    m_messageWidget->setText(i18n("Analysis finished."));
> +    m_messageWidget->setText(i18n("Analysis on %1 file(s) finished.", m_analysisTool->getActualFilesCount()));
>    } else {

Instead of writing file(s) you could also use the i18np form to get a better translation: https://techbase.kde.org/Development/Tutorials/Localization/i18n#Plurals

Think of languages where it's not possible to simply add a "(s)" to imply a correct plural form. Even in German it already starts to look awkward: "Analyse für 13 Datai(en) beendet" or so...

Same below.

REPOSITORY
  R40 Kate

BRANCH
  arcpatch-D17314

REVISION DETAIL
  https://phabricator.kde.org/D17314

To: gregormi, #kate, dhaumann
Cc: ngraham, dhaumann, kfunk, kwrite-devel, hase, michaelh, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181208/1364c49f/attachment-0001.html>