D16926: Review user interaction in session management

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.


  I agree this should go in (possibly with minor improvements I added as comments): The patch is already big enough, so I'd rather prefer continuation work on followup patches.
  
  Improvements I could imagine:
  
  - Rename "Open..." to "Open Session" without trailing '...'
  - Add column "Last Used" in the list view
  - Remove the Sort button in favor of making the columns clickable to sort the respective column
  - File open dialogs usually have a small 'config' button, so if we keep the Sort button, I would prefer to have a drop down menu that allows not only "Sort alphabeticaly" but also "Sort chronological" or similar.
  
  Please push this only to master and not the Applications 18.12 branch. This way, we have 4 months of testing.

INLINE COMMENTS

> katesessionmanagedialog.h:203
> +     */
> +    int m_sortOrder = SortChronological;
> +

I would prefer using the enum SortOrder here as type instead of an int. In fact, I would even be in favor of an enum class SortOrder { Alphabetical, Chronological };

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D16926

To: loh.tar, #kate, dhaumann, ngraham, #vdg
Cc: fabianr, anthonyfieroni, cullmann, kwrite-devel, #kate, hase, michaelh, ngraham, demsking, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181208/59744fa5/attachment.html>