D17318: WIP: Code Analysis: Show file extentions where the tool runs on
noreply at phabricator.kde.org
Sat Dec 8 13:29:59 GMT 2018
gregormi added inline comments.
> dhaumann wrote in kateprojectcodeanalysistool.h:62
> Why not return a QStringList? The current version just forces parsing in other places. :)
> Later: ok, now I see it's used in the regular expression. Still, I don't like how an implementation detail in a specific location (here: regex later) imposes design decisions here. And also in the UI, a label would rather be comma separated instead of | separated.
I added a comment about this.
> dhaumann wrote in kateprojectinfoviewcodeanalysis.cpp:105
> Why are there leading spaces in the label? Usually, spacing is up to the QStyle.
Fixed by using a button which is much less obstrusive
To: gregormi, #kate, cullmann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, hase, michaelh, demsking, sars
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel