D16779: kate-ctags plugin: support KDevelop (WIP)

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kate_ctags_view.cpp:73
> +    connect(updateDB, &QAction::triggered, this, [plugin, mainWin] (bool) {
> +            KateCTagsPlugin *p = dynamic_cast<KateCTagsPlugin*>(plugin);
> +            QDialog *confWin = new QDialog(mainWin->window());

Dynamic_cast is pretty expensive to not check against nullptr, use static_cast instead.

> kate_ctags_view.cpp:86-89
> +            confWin->deleteLater();
> +            confPage->deleteLater();
> +            controls->deleteLater();
> +            layout->deleteLater();

Add attribute to confWin deleteOnClose and make it parent of others.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D16779

To: rjvbb, #kate, sars, cullmann
Cc: anthonyfieroni, cullmann, sars, kwrite-devel, #kde_applications, glebaccon, hase, antismap, michaelh, iodelay, vbspam, ngraham, demsking, geetamc, head7, Pilzschaf, akshaydeo, surgenight, arrowd, kfunk, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20181205/6616aa43/attachment-0001.html>