D15081: replace own wildcard matcher with QRegularExpression combining all wildcards

[Dominik Haumann]

dhaumann added a subscriber: dfaure.
dhaumann added a comment.


  Do you need the public methods in Definition outside of KSyntaxHighlighting?
  
  In general: +1
  
  If you want this to be in 5.50, you need to get a +2 from @vkrause and ping @dfaure to retag.

INLINE COMMENTS

> definition.h:196
> +     */
> +    QRegularExpression extensionsAsRegularExpression() const;
> +

@since 5.50 or 5.51

> definition.h:202
> +     * @return regular expression matching them
> +     */
> +    static QRegularExpression convertExtensionsToRegularExpression(const QVector<QString> &extensions);

@since 5.50 or 5.51

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15081

To: cullmann, vkrause, dhaumann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180826/1132c5b5/attachment-0001.html>