D14956: avoid any heap allocation for default constructed Format() as used as "invalid"

Christoph Cullmann noreply at phabricator.kde.org
Mon Aug 20 20:10:19 BST 2018


cullmann created this revision.
cullmann added a reviewer: vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  Format() is used as invalid return value in some places.
  At the moment that does at least one heap allocation.
  Now only for formats loaded from the XML a heap allocation is done

TEST PLAN
  make && make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14956

AFFECTED FILES
  src/lib/format.cpp
  src/lib/format_p.h

To: cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180820/07820166/attachment-0001.html>


More information about the KWrite-Devel mailing list