D14856: Search: Add workaround for missing icons in Gnome icon-theme

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Aug 16 01:30:35 BST 2018


bruns added a comment.


  In D14856#309714 <https://phabricator.kde.org/D14856#309714>, @dfaure wrote:
  
  > I don't think so, because QIcon::fromTheme just creates an icon engine. The actual lookup happens when the first call to isNull or paint (etc) is made. None of which are going to be done on the fallback icon if the main icon can be found.
  >
  > So this looks fine to me, unless a profiler or strace says otherwise.
  
  
  strace confirms you are correct

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14856

To: sars, #kate, dhaumann, broulik
Cc: dfaure, bruns, broulik, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, demsking, cullmann, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180816/82778007/attachment.html>


More information about the KWrite-Devel mailing list