D14758: use view lines for wheel scrolling, not real lines

[Nathaniel Graham]

ngraham added a comment.


  In D14758#307417 <https://phabricator.kde.org/D14758#307417>, @brauch wrote:
  
  > In D14758#307401 <https://phabricator.kde.org/D14758#307401>, @ngraham wrote:
  >
  > > In D14758#307333 <https://phabricator.kde.org/D14758#307333>, @brauch wrote:
  > >
  > > > The "overly sensitive touchpad" issue seems to be missing accumulation of scroll events, so this patch to my understanding should not have it.
  > >
  > >
  > > Yeah, I don't think that's our bug, and we shouldn't work around it here. The reporter should file a bug against libinput.
  >
  >
  > Hmm, I understood this differently. I thought this happens when you react to each input event sent by the kernel, regardless of its delta, like e.g. the old gwenview code did which you linked: it just zooms in once per event. Thus devices which generate more events with smaller deltas zoom in faster, which is not good. And this bug is definitely at the application level, not in libinput.
  
  
  The Gwenview issue you're talking about manifested in touchpad scrolling feeling too fast. IMHO, touchpad scrolling in KTextEditor views feels perfect right now, so we don't have that particular issue. However yes, we should probably be taking into account the delta. But maybe that's material for another patch?
  
  I will indeed blog about this. If you'd like, I can request that people specifically test it out and offer feedback.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14758

To: brauch, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180813/b4798314/attachment.html>