D14274: Modelines: add byte-order-mark & small fixes
noreply at phabricator.kde.org
Mon Aug 13 07:13:15 BST 2018
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
<DetectSpaces /> is only a performance optimization, as it just skips over whitespaces before any of the costly rules are tried to match. I think that should just be added again.
Otherwise, I have no issues with this changes.
What was exactly the problem with the unit test? Having one would be nice.
R216 Syntax Highlighting
To: nibags, turbov, dhaumann, cullmann, vkrause, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel