D14762: Proposal: Add "None" highlighting to repository per default

[Christoph Cullmann]

cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  Rational: e.g. KTextEditor uses the repository to manage all syntax definitions.
  But to allow the user to use "None" as highlighting, we special case that everywhere and use there Definition().
  I think it would be much cleaner if the "None" definition is just part of the repository.
  An other approach would be to be able to add it later ourself.

TEST PLAN
  With this patch applied, I can just use definitions() everywhere in KTextEditor KateSyntaxManager without any special casing.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14762

AFFECTED FILES
  src/lib/definition_p.h
  src/lib/repository.cpp

To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180812/9f9383c1/attachment.html>