D14620: SymbolView: Add expand and parameter options to popup menu

[Kåre Särs]

sars requested changes to this revision.
sars added a comment.
This revision now requires changes to proceed.


  Hi,
  
  I was just about to commit this change when I noticed that:
  
  1. The "Expand Tree" option is enabled at startup even if tree-mode is not enabled.
  2. If I have "Expand Tree" disabled, no active symbol, a one tree expanded and I toggle "Show Parameters" it will collapse the tree.
  3. Toggling off "Expand Tree" does not collapse all trees. It seems it first collapses all and then expands the tree of the current item. Actually I noticed that this patch does not introduce this "feature".
  
  Can you fix at least 1)?
  
  2. and 3) might require a bit more changes to get them to work logically and this patch is not introducing the problem.
  
  Regards,
  
    Kåre

REVISION DETAIL
  https://phabricator.kde.org/D14620

To: loh.tar, #kate, sars
Cc: sars, kwrite-devel, #kate, michaelh, kevinapavew, ngraham, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180810/c2cd3595/attachment.html>