D14518: SymbolView: Improve "Not Supported" message

Kåre Särs noreply at phabricator.kde.org
Fri Aug 3 19:01:41 BST 2018


sars requested changes to this revision.
sars added a comment.
This revision now requires changes to proceed.


  While you update the string maybe you could remove the type (-1) and the comment about it?

INLINE COMMENTS

> plugin_katesymbolviewer.cpp:355
> +    QTreeWidgetItem *node = new QTreeWidgetItem(m_symbols, -1);
> +    node->setText(0, i18n("Sorry, \"%1\" is not supported yet", hlModeName));
> +    // Setting invalid line number avoid jump to top of document when clicked

I just tried this one and got: Sorry, "Normal" not supported yet :)

The "Normal" string will not come once we get the plain-text parser in, but I think we need a bit more explanation somehow.

Maybe: File type "Normal" not supoertd yet

REVISION DETAIL
  https://phabricator.kde.org/D14518

To: loh.tar, #kate, sars
Cc: kwrite-devel, sars, #kate, michaelh, kevinapavew, ngraham, demsking, cullmann, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180803/c094b8dc/attachment.html>


More information about the KWrite-Devel mailing list