D14538: Honor BUILD_TESTING
noreply at phabricator.kde.org
Wed Aug 1 17:29:20 BST 2018
heikobecker created this revision.
heikobecker added a reviewer: Kate.
Restricted Application added a project: Kate.
Restricted Application added a subscriber: kwrite-devel.
heikobecker requested review of this revision.
Although ecm_optional_add_subdirectory(autotests) allows to skip
building the autotests with -DBUILD_autotests=FALSE, it doesn't seem
reasonable to have two options controlling similar behaviour and
BUILD_TESTING is the de-facto standard for cmake and already used
when discovering Qt5::Test.
Furthermore it avoids a cmake warning when BUILD_TESTING is set to
FALSE because Qt5::Test is passed to target_link_libraries but
isn't a valid target.
Warning disappears and builds successfully
To: heikobecker, #kate
Cc: kwrite-devel, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KWrite-Devel