D14538: Honor BUILD_TESTING

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: Kate.
Restricted Application added a project: Kate.
Restricted Application added a subscriber: kwrite-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  Although ecm_optional_add_subdirectory(autotests) allows to skip
  building the autotests with -DBUILD_autotests=FALSE, it doesn't seem
  reasonable to have two options controlling similar behaviour and
  BUILD_TESTING is the de-facto standard for cmake and already used
  when discovering Qt5::Test.
  
  Furthermore it avoids a cmake warning when BUILD_TESTING is set to
  FALSE because Qt5::Test is passed to target_link_libraries but
  isn't a valid target.

TEST PLAN
  Warning disappears and builds successfully

REPOSITORY
  R40 Kate

BRANCH
  Applications/18.08

REVISION DETAIL
  https://phabricator.kde.org/D14538

AFFECTED FILES
  addons/backtracebrowser/CMakeLists.txt
  addons/filetree/CMakeLists.txt
  addons/project/CMakeLists.txt
  kate/CMakeLists.txt

To: heikobecker, #kate
Cc: kwrite-devel, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180801/963eba2c/attachment.html>