Fixing KTextEditor Autobraces

Milian Wolff mail at milianw.de
Tue Apr 17 19:23:54 UTC 2018


On Dienstag, 17. April 2018 18:08:58 CEST Sven Brauch wrote:
> Hi,
> 
> thank you very much for looking into this, I agree the behaviour is
> problematic.
> 
> Can you please create a diff using git and post it on
> phabricator.kde.org? Sharing changed copies of source files does not scale.
> 
> There, you can also comment on your own changes inline in the code,
> which will make it much easier to follow your explanations.
> 
> There are some methods which are called to move the cursor left/right.
> You could clear the stack there. You could also connect to the
> cursorPositionChanged() signal. But let's do further discussion on
> Phabricator :)

Also, do write unit tests. This documents your behavior, and makes sure it 
actually works. And it also verifies it will not be broken easily in the 
future.

-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20180417/931b2411/attachment.sig>


More information about the KWrite-Devel mailing list