D7660: Fix a regression caused by changing backspace key behavior

[Sven Brauch]

brauch reopened this revision.
brauch added inline comments.

INLINE COMMENTS

> katedocument_test.cpp:452
>      auto view = static_cast<KTextEditor::ViewPrivate*>(doc.createView(nullptr));
> +    view.config()->setBackspaceRemoveComposed(true);
>      doc.setText(QString::fromUtf8("व्यक्तियों"));

must be view->config ... how did this patch ever compile for you??

> katedocument.cpp:3190
> +        }
> +        if (!config()->backspaceIndents() || pos) {
> +            KTextEditor::Cursor beginCursor(line, 0);

pos is not defined at this place

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7660

To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, cullmann
Cc: brauch, mwolff, ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20171223/46fdbc90/attachment.html>