[Kwintv] Re: [PATCH] Per-channel picture settings

[Andras Mantia]

Dirk Ziegelmeier wrote:

> On Thursday 10 June 2004 23:32, Andras Mantia wrote:
> 
> Hm. I've also thinking about this for some time. I know you want that
> feature, but it's not that simple.

Yes, it's not complete what I've done and I'm not completely happy with it
(but it fits my needs. :-)).

> - Saving per-channel or globally must be configurable (I don't need per
> channel settings here, the picture is fine with the defaults).

I'm not sure if you really need to make it configurable. If you don't need
to change, well, you will not change, but it won't hurt you if the settings
are saved for every channel. To save some disc space settings for channels
that are the same as the global should not be saved independently. Two
functionality should be provided:
- reset to default (means reset to the application shipped default)
- reset to global setting

> - Ideally, it should be configurable _per channel_ to use the global or
> channel-specific settings.

I really think this is over-configureability.

> - Find a good way (UI!) to distinguish channel specific and global
> settings, edit and reset them. Something like "apply to all channels",
> reset all channels to defaults" and so on.

Yes, in the Picture Editor we can have some buttons to make the current
settings valid for every channel or set it to be the default (without
changing the other channels).  Regarding the configuration:
- the Picture Settings from the main and context menu should by default
configure the per channel settings and provide two checkboxes for "Use as
default" and "Apply to every channel".
- the Picture Settings from the Configure Kdetv dialog should change the
defaults and provide an "Apply to every channel" checkbox.

> - Be backward compatible. I can't suddenly start to save everything per
> channel without any noticeable GUI change.

I don't find this to be a big problem.

> - Compatibility between plugins. Example: v4l has whiteness
Does it? ;-) It does not have any effect here. Must be because of bt848.

> , xv has not. 
> So a way to store Plugin (or device?) specific values has to be developed
> first. The channel file should have a section with a key (e.g. device
> name) for each channel that stores some key-specific values. I alread use
> some hacks to keep channel files compatible (e.g. xv changed encoding
> names on my new SuSE to upcase, didn't investigate whether it's the kernel
> or XFree that coused it). Maybe channel files should be plugin-specific
> anyways.
I don't know. I like that I don't have to use two channel files (one for xv
and one for v4l). But I also wrote in my mail that picture settings are
plugin and channel dependent (and this is how they are stored now).

> - I don't like to clutter the pic settings into the kdetv config file.
> They belong into the channel file. (Yes I know the global pic settings are
> in the kdetv file).

I don't like it either, and yes, the should go into the channel config file.
Just that under a plugin name:
<picturesettings>
  <plugin name="v4l">
     <brightness>12445</brightness>
      ...
  </plugin>
   <plugin name="xv">
     <brightness>32445</brightness>
        ....
   </plugin>
</picturesettings>

> - I don't want to commit an intermediate solution. I'd get lots of bug
> reports or wishes if I'd do that.

Well, we don't need to commit what I've done. It's fine for me here, just
that I must be careful not to commit to the CVS by accident. ;-)

> Since implementing all of the above takes some time, I didn't start doing
> it up to now. And hey, it's summer, beautiful wheather, time to go
> bicycling or swimming. I only have the motivation to fix bugs or implement
> things _I_ (how selfish ;-), but that's how free software works) am
> interested in.

Yeah, I know and this is why I did this one. I'm interested in. ;-) Well,
maybe I will come up with a nicer solution in the near future.

Andras

> 
> Dirk

-- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org