[Kwintv] [PATCH] devfs support for VBI decoder plugin

[George Staikos]

On Wednesday 14 January 2004 07:34, Neil Macvicar wrote:
> Hi all,
> 	A quick patch for the VBI decoder to support both vanilla /dev and devfs.
> I've also put in a few more debugs and intend to play with it further. I
> removed the default behaviour of automatically assuming /dev/vbi at
> startup. You may or may not like that bit, since most people do use vanilla
> /dev - but even then, assumptions still irk me. I much prefer the user to
> configure the option than have a half-baked 'autodetect'. An ideal solution
> would be to find the VBI device associated with the current video device
> and use that instead. Feedback welcome.

  In general it's ok but I don't really like the patch.  Comparing and 
assigning QString to "NULL" is not a good idea.  It's Dirk's code anyhow, so 
it's up to him how he would like to deal with this.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/