[Kwintv] Channel Import/Export patch
Dirk Ziegelmeier
dirk at ziegelmeier.net
Wed Sep 24 23:28:05 CEST 2003
Hello List,
second iteration of the patch is ready.
Change summary:
- remove Channels->Open menu
- add import/export for all supported channel formats
- remove "channel plugins" page in settings dialog
- config dialog is no longer modal, e.g. changing the device/source while the
dialog is open is not a good idea...
- channel files are now device specific and configurable in "general" page.
They have been device AND source specific in the past, so this will break
backwards compatibility since the qtvisionrc config file format changes (hey,
we are in kdenonbeta :-) )
- enter sourcemanager. This cleans up with the problem that the video source
must be dropped before showing a device selection dialog. Consequently,
"device" settings dialog page returns. Also removes some code duplication for
creating a devices/sources/norms mapping for config dialogs and makes the
device-specific channel filename config page possible without writing the
video plugin scanning code a third time.
- hack: The config pages are not independent of each other, so the apply order
matters. Does anyone have a suggestion for a clean solution? see
settingsdialog.cpp
- settingsdialog: do not work on a copy of the ConfigData class. This fixes
(amongst avoiding other problems) the following situation: channel file name
for a device ("general" page) and the device ("device" page) is changed in
settings dialog, then apply is pressed. The video source is changed, thus the
channels are reloaded from another file. Then the new settings are copied
over, so the current (new device) is using the channels file for the old one
(cfg->channelFile contains filename for current device). I hope to get an
idea on how to decouple these dependencies in a clean way...
General KDE problem:
- delete qtvisionui.rc if you have configured your own keyboard shortcuts to
see the menu changes.
Since the changes are quite intrusive I would like to ask one or two
experienced developers to review and try the patch before I apply it.
TIA,
Dirk
--
Dirk Ziegelmeier * dirk at ziegelmeier.net * http://www.ziegelmeier.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: impex.zip
Type: application/x-zip
Size: 26854 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kwintv/attachments/20030924/613a686a/impex-0001.bin
More information about the kwintv
mailing list