[Kwintv] [PATCH] Fixed Telex Plugin

Jan Hambrecht jan.hambrecht at gmx.net
Wed Oct 8 20:28:00 CEST 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi...

I fixed some bugs in the telex plugin. What i have done is:

in telex.cpp
- -------------
Moved code which creates the decoder thread from constructor to showDisplay 
method. That prevents the plugin from trying to access the vbi device too 
early when starting qtvision and returning with an error. Added some checks 
to detect if the decoder is created when accessing a page with setPage().
Added a method setActive(bool) to the decoder thread that sets a flag which 
sends the thread sleeping when no teletext page is shown. That prevents the 
plugin from eating the cpu cycles even when not active.

in qtvision.cpp
- ----------------

Moved the destruction of the MiscManager object from qtvisions destructor to 
the slot aboutToQuit. That fixes the crash of qtvision when exiting and the 
telex plugin is loaded. It seems when the plugin tries to remove its toolbar 
buttons, the mainwindow is already destroyed. 

Attached is a patch against current cvs. Please review and commit if ok.

Ciao Jan

- -- 
Jan Hambrecht
jan.hambrecht at gmx.net
www.gfai.de/~jaham
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/hEkiLC805XVK6hcRAkLdAJ9Z5/IXc0CfvG2DRvUnQrfEVKhO6QCg2B6N
jaz/FNJfFnH7AlVsPDr6+j0=
=0Jz/
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: telex.patch
Type: text/x-diff
Size: 4128 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kwintv/attachments/20031008/fe5fa3ec/telex.bin


More information about the kwintv mailing list