[Kwintv] Re: kdenonbeta/kwintv3/qtvision

George Staikos kwintv@mail.kde.org
Wed, 16 Oct 2002 21:38:17 -0400


Please apply this to CVS.  We'll see how it goes and tweak it from there.  
Overall I think we are making progress towards a good compromise and system 
here. ;)


On October 16, 2002 08:38, Rizsanyi Zsolt wrote:
> On Wednesday 16 October 2002 06:05, George Staikos wrote:
> > On October 15, 2002 23:58, Dawit Alemayehu wrote:
> > > CVS commit by adawit:
> > >
> > > - Change the channel intelligently.  Now the delayed change is
> > > activated iff the entered numbers are ambigous.  It uses the highest
> > > configured channel to handle this as discussed.
>
> I think that the implementation has some inconsistencies/bugs.
> My main problems are:
> - you cant select a channel number less than 10 with one keypress even if
> you have only less 10 channels configured
> - you could not select channels less than 10 without delay with even a
> leading zero entered if the max channel is *10 bigger than the channel you
> want to enter
> - there is no way to select channels without delay, even if you enter
> leading zeros
> - it does not work with channels > 1000 :)
>
> Here is my implementation which should fix all those above issues. And the
> code is simpler too...
> Should I commit it, or somebody wants to veto me :)
>
> Basic description of usage:
> - you enter the number, and if by entering any more digits the number would
> be larger than the largest channel number, then the channel is changed
> without delay (else there is the usual delay)
> - if you enter leading zeroes then with every leading zero the max number
> to compare is divided by 10
>
> Here is how it works for the different max channel number:
> - max channel num < 20
> you enter the number and the channel is changed without delay
> there is no use to enter a leading zero (but you can)
> - max channel num < 200
> if you want to select channel > 20 you just enter the number
> if you want to select channel < 20, then you enter the number, and wait the
> delay OR you enter a leading zero and the channel is changed without delay
> - max channel num < 2000
> if you want to select channel > 200 you just enter the number
> if you want to select channel < 200 but > 20, then you enter the number,
> and wait the delay OR you enter a leading zero and the channel is changed
> without delay
> if you want to select channel < 20, then you enter the number, and wait the
> delay OR you enter TWO (2) leading zeros and the channel is changed without
> delay
>
>
> Huh. I took more to write this down than the code :)
> But I hope this will convince everybody :)
>
> Regards
> Zsolt

-- 

George Staikos