[Kwintv] Patch to fix memory leak when lirc-support is in
Michael Kedl
kwintv@mail.kde.org
15 Oct 2002 10:43:57 -0400
I didn't even know it had lirc support :-)
I guess I'll have to recompile now that I installed lirc.
I was getting it to "mostly work" without direct lirc -> qtvision,
but it will probably work better with your code.
On the subject of inputs and where to hook them in, I hope you can make
them consistant across all the screens, normal, fullscreen, tv mode,
etc.
I have been hacking on the code to get channel
up/down/mute/volup/voldown, etc working in all screens.
So far it "works" but I don't quite understand the kde shortcut stuff
yet so it doesn't work "right". It is hard coded to certain keys.
I'll let you know if I get it working "right". I'm guessing its just a
few lines of code.
Mike
On Tue, 2002-10-15 at 09:50, George Staikos wrote:
> On Tuesday October 15 2002 07:35, Rizsanyi Zsolt wrote:
> > > > Correct me if I'm wrong, but if an QObject has a declared parent, then
> > > > it will be automatically deleted when the parent is deleted.
> > >
> > > Really? OK, I didn't know that.
> > >
> > > I ran qtvision through LeakTracer (http://www.andreasen.org/LeakTracer/)
> > > and it found this to be a memory leak - but you may be right.
> > >
> > > > So this fix is not needed... (and even could cause a crash because of
> > > > double deletion)
> > >
> > > My added "delete lirc" doesn't make it crash.
> >
> > I'm not a qt guru either. I just read that in the Qt documentation.
> > But if your leaktracer shows that, then maybe somebody with more knowledge
> > could help us out.
>
> Furthermore, if it is only created once and deleted on exit, then it doesn't
> matter because it can't leak more than once which is ok.
>
> After seeing this patch, I'm wondering if mainwindow is the right place to
> put the lirc code though. This code should really work in other clients too
> (the panel applet, extension, etc). Is there a better place for it?
>
>
> --
>
> George Staikos
>
> _______________________________________________
> kwintv mailing list
> kwintv@mail.kde.org
> http://mail.kde.org/mailman/listinfo/kwintv
>