D8388: Do not hardcode unhovered windows brightness on present windows effect

[Méven Car]

meven added a comment.


  > If you don't want to maintain an option in the UI - cause the amount of people using it - why not just add it to the config file. I would say, that the default does not really matter. Both solutions are working somehow, and most people won't notice the difference.
  
  
  
  In D8388#321816 <https://phabricator.kde.org/D8388#321816>, @zzag wrote:
  
  > > From KWin side: PresentWindows is actually in change freeze since a long time. The code is fragile and I don't like to see it being changed again. The code is straight forward and I don't think it would cause issue, but I'm looking at the bigger picture here with having blocked changes for years because the code is fragile.
  >
  > That's pretty good argument!
  >
  > Frankly, dimming windows is not really good idea, imho. Adding outline around windows would be much better, imho. On the other hand, as Martin said, the code is fragile. E.g., in some cases, calculateWindowTransformations can bring KWin to knees.
  >
  > Maybe we could come up with something better when we port the Present Windows and the Desktop Grid effect to QML?
  
  
  The UI part was never the troubling part here.
  
  The parent bug of 385522 https://bugs.kde.org/show_bug.cgi?id=303438 was closed due to the fact the presentwindow effect is to be deprecated in favor of the new overview effect that does not dim other windows in the first place.
  
  I think we can close this differential, the overview effect show replace the presentwindow effect for Plasma 5.24 I believe.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8388

To: salvacorts, #kwin, #vdg, #plasma
Cc: meven, farion, jgahde, ndavis, ahmadsamir, Zren, muratcileli, zzag, graesslin, ngraham, kwin, #kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20210929/e5c7461d/attachment.htm>