D29791: [kcm/kwinrules] Detect also window complete class

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> meven wrote in rulesmodel.cpp:181
> Could you `for (const RuleItem *rule : qAsConst(m_ruleList)) {` c++ style

Or you could use `std::find_if`

> rulesmodel.cpp:239
> +{
> +    if (key == QStringLiteral("wmclasshelper")) {
> +        setData(indexOf("wmclass"), value, RulesModel::ValueRole);

Compare with `QLatin1String`

> rulesmodel.cpp:401
> +                                              RulePolicy::NoPolicy, RuleItem::String,
> +                                              i18n("Window whole class"), i18n("Window matching"),
> +                                              QIcon::fromTheme("window")));

"whole class" reads odd imho but I'm not a native speaker

REPOSITORY
  R108 KWin

BRANCH
  wmclasscomplete

REVISION DETAIL
  https://phabricator.kde.org/D29791

To: iasensio, ngraham, #kwin, #plasma, meven
Cc: broulik, davidedmundson, meven, anthonyfieroni, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200528/9ebc58f7/attachment.htm>