D29791: [kcm/kwinrules] Detect also window complete class

Ismael Asensio noreply at phabricator.kde.org
Wed May 27 20:04:05 BST 2020


iasensio added inline comments.

INLINE COMMENTS

> meven wrote in rulesmodel.cpp:141
> Make those index values constants or at least less hard coded.

Good advice. Now, it uses a `indexOf()`method to get the index of a rule.
Also, to keep the philosophy of keeping the `setData()` method agnostic to specifics of certain rules, I've delegated the internals to another method.

REPOSITORY
  R108 KWin

BRANCH
  wmclasscomplete

REVISION DETAIL
  https://phabricator.kde.org/D29791

To: iasensio, ngraham, #kwin, #plasma
Cc: meven, anthonyfieroni, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200527/6b7f7fa8/attachment.htm>


More information about the kwin mailing list