D29263: Position OSD a bit farther down

Vlad Zahorodnii noreply at phabricator.kde.org
Thu May 21 07:50:45 BST 2020


zzag added a comment.


  In D29263#673250 <https://phabricator.kde.org/D29263#673250>, @ngraham wrote:
  
  > The existing magic number is also totally random, and does not even match
  
  
  I wouldn't say that fractions such as 1/2, 1/4, 1/3, 2/3 and so on are that random.
  
  > what it says it will do (it results in an OSD position about 45% up, not in the bottom third as it claims.
  
  The placement area and the screen area are different.
  
  > Do you have a suggestion?
  
  `area.top() + 2 * area.height() / 3 - c->height() / 2`?
  
  F8343859: Screenshot_20200521_094857.png <https://phabricator.kde.org/F8343859>
  
  F8343861: Screenshot_20200521_094922.png <https://phabricator.kde.org/F8343861>

REPOSITORY
  R108 KWin

BRANCH
  position-osd-a-bit-farther-down (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29263

To: ngraham, #kwin, #vdg, broulik, ndavis
Cc: meven, ndavis, niccolove, baberts, davidedmundson, filipf, zzag, kori, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200521/0ec51780/attachment.htm>


More information about the kwin mailing list