D29263: Position OSD a bit farther down

[Nathaniel Graham]

ngraham added a comment.


  In D29263#673061 <https://phabricator.kde.org/D29263#673061>, @ndavis wrote:
  
  > In D29263#673056 <https://phabricator.kde.org/D29263#673056>, @ngraham wrote:
  >
  > > In the absence of a way for the Global Theme or (proposed-but-not-yet-existing OSD themes) to set a custom OSD position, are #KWin <https://phabricator.kde.org/tag/kwin/> people okay with this patch to improve the positioning of the new OSD?
  >
  >
  > Non-Breeze OSDs will be affected? If so, that seems bad.
  
  
  Yes
  
  In D29263#673062 <https://phabricator.kde.org/D29263#673062>, @niccolove wrote:
  
  > How do you think about putting it horizontally centered at the top of the screen? Maybe even avoiding panels, if possible?
  >  I'd be fine both with "floating a bit under the panel" and "merged with screen/panel top" like krunner.
  >
  > I don't think it's a problem to change this even for non-breeze themes.
  
  
  That seems like it could be a sensible solution, yeah.
  
  However @ndavis might be right that we should come up with a way for themes to override the positioning first--especially if we do that. A square OSD will look kind of weird jammed up at the top of the screen.
  
  I don't think this patch in its current form will cause problems for 3rd-party themes, though. The new position is not much farther down than the current one. It's a pretty small change.

REPOSITORY
  R108 KWin

BRANCH
  position-osd-a-bit-farther-down (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29263

To: ngraham, #kwin, #vdg, broulik, ndavis
Cc: ndavis, niccolove, baberts, davidedmundson, filipf, zzag, kori, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200519/45b474e8/attachment-0001.htm>