D29783: [kcm/kwinrules] Fix placeholder message in RulesEditor

Nathaniel Graham noreply at phabricator.kde.org
Fri May 15 17:51:35 BST 2020


ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  The problem with setting both top and bottom anchors (or using `anchors.fill`) is that it stretches the component and distorts the spacing between its internal items. However this instance doesn't have multiple items, so it's fine. However please add a comment mentioning this, should someone ever add a text label or an icon in the future.
  
  Probably safe for landing on 5.19.

REPOSITORY
  R108 KWin

BRANCH
  fix/placeholder

REVISION DETAIL
  https://phabricator.kde.org/D29783

To: iasensio, ngraham, broulik, #vdg, #plasma
Cc: kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20200515/260e679e/attachment.htm>


More information about the kwin mailing list